fix: exclude scoped theame from external plugins #5091
Merged
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test cli-preview |
1 similar comment
|
test cli-preview |
DimitarTachev
approved these changes
Oct 22, 2019
KristianDD
deleted the
kddimitrov/exclude-scoped-theme-from-external-plugins
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Currently the
@nativescript/themeis listed as external plugin. This won't allow users to switch between themes.What is the new behavior?
The
@nativescript/themeto be included inside the vendor file and synced to the Preview app.Fixes/Implements/Closes #5094